ChainSafe / ChainSafe/forest

Only use `register_async_method` when needed

Open
#3,967 0 comments 0 reactions 0 assignees View on GitHub
Priority: 4 - Low Type: Enhancement
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 5h
Merged PRs (30d)
65

Description

**Issue summary**

Most of the methods that we are registering in our RPC module are `async`. Some are not (e.g., `chain_get_message`) and can use `register_method` instead.

**Task summary**

- [ ] Make a list of those async functions
- [ ] Change them to synchronous functions and register them accordingly

**Other information and links**

https://docs.rs/jsonrpsee-core/0.21.0/jsonrpsee_core/server/struct.RpcModule.html#method.register_method

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.