ChainSafe / ChainSafe/forest

`AnyCar` and `into_dyn` should be redesigned

Open
#3,647 0 comments 0 reactions 0 assignees View on GitHub
Priority: 4 - Low Type: Enhancement
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 5h
Merged PRs (30d)
65

Description

https://github.com/ChainSafe/forest/blob/f04adb8eae13c96b5750b875c6dd8c9543351773/src/db/car/any.rs#L22-L26

The `AnyCar` has a type hole on the third discriminant, and the `into_dyn` methods everywhere are a serious code smell.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.