message processing warts
Open
Priority: 4 - Low
Type: Enhancement
- Dominant language
- Rust
- Stars
- 697
- Forks
- 200
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 65
Description
- [ ] Document why it's ok to ignore the cron error: https://github.com/ChainSafe/forest/blob/7e8d98141051d18996200ec3617a9b4e60c11620/src/interpreter/vm.rs#L344-L346
- [ ] Consider inlining message processing: https://github.com/ChainSafe/forest/blob/7e8d98141051d18996200ec3617a9b4e60c11620/src/interpreter/vm.rs#L293
- [ ] Refactor callback for message replay: https://github.com/ChainSafe/forest/blob/7e8d98141051d18996200ec3617a9b4e60c11620/src/state_manager/mod.rs#L493-L518
- Callback should return `ControlFlow`, not `Result` if it's going to break.
Contributor guide
Assessment
This issue has not been assessed yet.