ChainSafe / ChainSafe/forest

Validation should fail before we hit the end of a snapshot

Open
#3,180 0 comments 0 reactions 0 assignees View on GitHub
Priority: 4 - Low Type: Enhancement
Dominant language
Rust
Stars
697
Forks
200
Avg merge
1d 3h
Merged PRs (30d)
64

Description

We should tell the user if they're trying to validate too many tipsets (e.g more than their snapshot will allow)

> Validation is expected to fail when you reach the tail of the snapshot `--height=-1100` is as far as you can go

_Originally posted by @aatifsyed in https://github.com/ChainSafe/forest/issues/3179#issuecomment-1633038834_

Contributor guide

Open the contributing guide

Research direction

Start by tracing the validation path for tipsets against the snapshot boundary. Reproduce validation with a height beyond the snapshot, such as `--height=-1100`, and confirm it fails before reaching the snapshot tail with a clear error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.