ChainSafe / ChainSafe/EthereumRPCSharp

Support ICAP address checksum conversion

Open
#21 0 comments 0 reactions 0 assignees View on GitHub
Type: Feature
Dominant language
C#
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

**Context**
When we use the method **ConvertToEthereumChecksumAddress** located in **AddressExtensions** class it doesn't support to send a ICAP address in the parameter because it returns a wrong address.

**Solution**
Implement something similar to ethersjs in https://github.com/ethers-io/ethers.js/blob/0802b70a724321f56d4c170e4c8a46b7804dfb48/lib.commonjs/address/address.js
Screenshot 2023-04-17 at 12 18 22

**Examples**
XE21ERF4STLB4CJC4UJJTZHGOOGJLHSGKIN returns 0x7E5F4552091A69125d5DfCb7b8C2659029395Bdf
XE87G9LDNFQOV62I76F9M63NWLY9OAF48AE returns 0x8b4130A0cA7970b8a8A3b8Ec8a284175949d99F6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.