ChadCSong / ChadCSong/ShineButton
ShineView didn't remove after shine finished.
Open
- Dominant language
- Kotlin
- Stars
- 4.2k
- Forks
- 540
- PR merge metrics
- No merged PRs in 30d
Description
Following change to fix this:
In ShineView lin 128
`
shineButton.removeView(ShineView.this);
`
replace with:
`((ViewGroup) ShineView.this.getParent()).removeView(ShineView.this);`
Or modify ShineButton.removeView function.
Contributor guide
Research direction
Inspect ShineView at line 128 and the ShineButton.removeView function. Compare the current removal call with the proposed parent ViewGroup removal, then verify that ShineView is removed after the shine animation finishes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100