CesiumGS / CesiumGS/cesium

PolygonOutlineGeometry.fromPositions(options) does not pass the `vertexFormat` parameter

Open
#9,980 0 comments 0 reactions 0 assignees View on GitHub
category - architecture / api category - polygons/geometry type - enhancement
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

It's not possible to create a PolygonOutlineGeometry using `Cesium.PolygonOutlineGeometry.fromPositions({ vertexFormat, ...})` since it is not supported.
However, when looking at the code it is just a wrapper for instantiating `PolygonOutlineGeometry` directly. I would have expected the `fromPositions` method to include all the options that `PolygonOutlineGeometry` accepted.

https://cesium.com/learn/cesiumjs/ref-doc/PolygonOutlineGeometry.html?classFilter=outlinegeom#.fromPositions
https://github.com/CesiumGS/cesium/blob/1.88/Source/Core/PolygonOutlineGeometry.js#L534

`PolygonGeometry.fromPositions` does correctly pass the `vertexFormat`:
https://github.com/CesiumGS/cesium/blob/1.88/Source/Core/PolygonGeometry.js#L877

Contributor guide

Open the contributing guide

Research direction

Start in Source/Core/PolygonOutlineGeometry.js around line 534 and compare its fromPositions implementation with PolygonGeometry.js around line 877. Done means PolygonOutlineGeometry.fromPositions accepts and passes vertexFormat consistently with PolygonGeometry.fromPositions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.