CesiumGS / CesiumGS/cesium

gltf-pipeline as an npm module?

Open
#9,614 3 comments 0 reactions 0 assignees View on GitHub
category - packaging & tooling
Dominant language
JavaScript
Stars
15.8k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

@ebogo1 this is related to #9473

Today I updated `gltf-pipeline`, and noticed that the way we add the changes to Cesium are:

1. run `npm build-cesium` in `gltf-pipeline` (Not sure everything this build step does, but it does take some Node.js code involving `Buffer` and adapts it for the browser according to @lilleyse )
2. copy the output files into `Source/ThirdParty/GltfPipeline`
3. commit the changes

Could this workflow be changed to use `npm` instead? e.g. release `gltf-pipeline` and then `npm install` in `cesium`?

Contributor guide

Open the contributing guide

Research direction

Start by tracing the `npm build-cesium` workflow in `gltf-pipeline` and how its output is consumed from `Source/ThirdParty/GltfPipeline` in Cesium. Compare that manual copy flow with installing a released npm package, and consider the work done when Cesium can build and use the dependency without committed copied output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.