CesiumGS / CesiumGS/cesium

ClassificationModel crashes if glTF model doesn't have indices

Open
#9,459 0 comments 0 reactions 0 assignees View on GitHub
type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

`ClassificationModel` crashes if the glTF model doesn't have indices.

![Selection_699](https://user-images.githubusercontent.com/915398/113202909-59a97100-9239-11eb-91a3-e5ec485edd49.png)

For testing:

[Sandcastle](http://localhost:8080/Apps/Sandcastle/index.html#c=jVNrb9owFP0rUT4FiZmUl9qOVptCyswIlJKWgSJVJjGtg2OndkggE/99DmlR17KuUaTEvufc17k3RUJLCc6w0C40hjPNwpKsI3C3vzM83d+fLc4SRBgWnl7VfntM0xIshLq5FjwlARbnL0RfYJTgKRc0cEuIUal6bFf56jGPpSpcQiiWOPk7XvlpdN3SaOxjrAU9+IWc3WDJ18LHYCl49F0qGAyMpnnabh8ilKUA6WOGQSxIRBKSYglQEBjPcV/Bcs4jl782lBn6FElJlsRHCeHMPeT7kfci3//V89mKmo1W+7nNxYN8JYJ0+Qqzc83T8bb/uOj5ZET68DaHJ0MCJWQ3Ld+CbbiKf91Z/TOgQE9Bb6VAMJ9FN3SWO82hZebznp0N3HHDCZ1kNB03Z1szG7p+NuzO6cx1stF0RgZWP54rZ6NJRtD0yoQh3wxDW3HsjRPC+nIMrki7bqGz4c+nwei+MXicbsIorM9+nM67YWbbDp9/6UGSB9djx9PLOnaFSMXPm+5uY3xoifXOBCx7Am+d+0b33oUDe+9iV/FYKdZRoYBMthT/e7wmhbkUxOeUi6Kn4mGBjHqrVdXM8gWtihr1T0zV0RQ+yi5CGxKto4laFMwmMfKxLQQv1s8EpuLpVb2zr+DyRf9vJIq5SIrhMQCoJTiKqdoxWVus/ZXy6EtZBCygndpraicgqUaCiyNbXKqgLMs1pROSY0+/7NQU/h2VchQQ9jBKsaBoW8AeTy4H5SUAoFNTx+PMhHO6QOKN5z8)
[box-without-indices.zip](https://github.com/CesiumGS/cesium/files/6239100/box-without-indices.zip)

Contributor guide

Open the contributing guide

Research direction

Start with the linked Sandcastle reproduction and box-without-indices.zip, then trace the ClassificationModel crash while loading the glTF asset. Done means a glTF model without indices no longer crashes and the classification behavior works as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.