CesiumGS / CesiumGS/cesium

`GeoJsonDataSource` should have a `process` method similar to CzmlDataSource

Open
#9,275 1 comment 0 reactions 0 assignees View on GitHub
category - data sources type - enhancement
Dominant language
JavaScript
Stars
15.8k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

The current implementation of `GeoJsonDataSource` does not give any way to dynamically load features in multiple batches, because [it always clears the entity collection](https://github.com/CesiumGS/cesium/blob/1.76/Source/DataSources/GeoJsonDataSource.js#L1042) when `load` is called. `CzmlDataSource` offers a `process` method which simply calls the underlying (private) `load` method without clearing existing entities. This method should be added to `GeoJsonDataSource` for consistency.

(I previously had a comment here about doing the same thing for `KmlDataSource`, but on reflection that doesn't make sense. CZML and GeoJson are based on packets/features and it makes sense to support stream-wise loading; KML is a document format that usually includes e.g. style references and it makes sense to only support loading when the whole thing is available.)

Contributor guide

Open the contributing guide

Research direction

Start in Source/DataSources/GeoJsonDataSource.js around the load implementation at line 1042, then compare it with CzmlDataSource's process method. Define completion as GeoJsonDataSource supporting multiple batches without clearing the existing entity collection, consistently with the stated CZML behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.