CesiumGS / CesiumGS/cesium

Why is AnimationViewModel setting shouldAnimate in the _canAnimate getter?

Open
#8,469 0 comments 0 reactions 0 assignees View on GitHub
category - widgets type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Widgets/Animation/AnimationViewModel.js#L233

This is a weird side-effect and caused some unexpected behavior in another app where we weren't using the animation widget directly.

Contributor guide

Open the contributing guide

Research direction

Start by reading Source/Widgets/Animation/AnimationViewModel.js around line 233, then trace the _canAnimate getter and its callers to understand the side effect. Done means the getter no longer causes unexpected state changes for applications that do not use the animation widget, with the existing animation behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.