CesiumGS / CesiumGS/cesium

Precision errors in tests in Firefox on MacOS

Open
#8,430 0 comments 0 reactions 0 assignees View on GitHub
test failure
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

The following tests are failing due to small precision errors as of the 1.64 release. Epsilon 7 would probably be enough for these tests.

* `Core/ApproximateTerrainHeights getMinimumMaximumHeights computes minimum and maximum terrain heights`
* `Core/ApproximateTerrainHeights getBoundingSphere computes a bounding sphere`
* `DataSources/KmlDataSource Geometry Point: correctly converts coordinates using earth ellipsoid`
* `DataSources/KmlDataSource Geometry Point: correctly converts coordinates using moon ellipsoid`
* `DataSources/KmlDataSource Geometry Polygon: When loaded with the Ellipsoid.MOON, the coordinates should be on the lunar ellipsoid, otherwise on Earth.`
* `DataSources/KmlDataSource Geometry Polygon: When loaded with the default ellipsoid, the coordinates should be on Earth.`

Contributor guide

Open the contributing guide

Research direction

Locate the six named Core and DataSources tests and run them in Firefox on macOS to reproduce the precision failures. Check the existing epsilon assertions and verify whether changing them to epsilon 7 makes all listed tests pass without weakening unrelated checks; done means the tests pass on the affected platform.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.