CesiumGS / CesiumGS/cesium

TerrainFillMesh unit tests fail under Firefox Headless (and maybe others)

Open
#8,068 5 comments 0 reactions 0 assignees View on GitHub
test failure
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

Under Firefox Headless (and possibly other options) a bunch of `TerrainFillMeshSpec` unit tests fail with the below error:

```
renderState.lineWidth is out of range. Check minimumAliasedLineWidth and maximumAliasedLineWidth.
```

Not sure if this is exposing a bug in our code we previously missed, or if the test is just bad.

Contributor guide

Open the contributing guide

Research direction

Start by running the TerrainFillMeshSpec unit tests under Firefox Headless and capture which cases produce the renderState.lineWidth error. Read the TerrainFillMesh test setup and the relevant rendering code to determine whether the failure is caused by the implementation or by invalid test expectations. Done means the affected tests pass reliably under Firefox Headless and other tested options.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.