CesiumGS / CesiumGS/cesium

Silhouette highlight post process not working when log depth is disabled

Open
#7,705 1 comment 0 reactions 0 assignees View on GitHub
type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

[Sandcastle](https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=7Vr/b9rIEv9X9vILoCMGAmlIGqKXAHdBR5Kq0DtVTVQt9oL3dfFa3jWEd8r//mbX3w0GkqJ3elWR2gR7dr7PZ2ZWqdXQNRJ07jKCLDLniE9Rs4fGlBGBpgRL3yPIpeY36szQkkob2XxBPIQdCwnCiCnRhNh4Qbn36NRq6ManzFK0FpYYmdz3JBErxfX+cxc9uMTpqRcu9yRmF8iW0r2o1ZbLZcNwVqYx44uaoJLULE6lrFGHSoolXRBRa1rHk5C54eIZeXQW2EMLSpagTgc5ZIm6RFB/bvypn5VLpv7a5Y7E1CFeqYr+fnQQfCTxPHj0weMLahHvIjpoemAw+Yt7zBoHJOXKo/NSef/ogDTN1RAmcYgxY3xCDIu40h4TIa9nQCtkeAi0kZ5P3ufOMD7DHnhwTs2eOnjjT6da9SlmgmgZ4MARkUjaBAWmM2TiOfGwthNJjhjn3xCW6A47NpYSO4EbQuoPHJxHudIgNKmLVQAodprG1OPzHpl5hIjy8VnLqDfa7UazftKu109a7Spq1Y13541Gq9lsnjVa7ZNGFZ2dNpXxKQkPHiXgz1BIyum3BKvQfKDStD9yxjLiThrGyVn77Lx91j45b7abp1V0DM+areZ5/fS03j47ab0DcXWjftZ4d37aOAfVztutxmkl78TAHYYgUkW5HAbUghhQR2t1kfdFNSDhieIXG4wJqYhjjT3siCn35nFa3GHp0eeWMej178eD8ec4JSBcQ44tHS+V3lF+CiRV/RAZuC78kvVX8KPZGwcvy38j32OxyAF3PhIB1WMS7chrATQDq3x61mpU0MuaW1yPzqmuEwNbVjmUGGt5O74bIlW3DK8Q2IaEzZeqSqMKd8CtCEI6574gijDQXD1+CI91kMVNfw4OC+ukz4j6Vi5ZdFFKaWRGBWdgF+rd6trglXKKlaJNfTVMhoW4Vxp0UGmCzW+Wx91SjkjIFYOKo8INlCk53CGbidykCkp4IjjzZQHlhEvJ54quvpmAkaksfv2l5HLqAJockwV4QpSedigGsVFeB6KW+1ygEtg/87gPfuOMe9olDJ6VolgOHJWcQQXiCfcDuDB9zwMV2CpEZWJFsQ0iGT/tRCAYvr5AIIpMIV5WUikzKCam5V9kclY90ZAYKXPtQMlIKgHhJ/9WzWBpU9OGRsEYNApmQaVN+V5q6rRU1BP+jMIwZ1XvB4IyVRQ8K8eJ/juUGViDfSaRjp3JoHchG9oVA6xVMpY2AcfFYqlADpe6xYEy4NPkWCBe/3obMuiguOwA2JyRi03SV7EPCYwZlKnj+vLaVAEqh2qOctTjlUuMYf+38dfucND9I1Z/MIVezGzuEwmojTDoJ3xXNUuITupVpL0Aj6EJ85PaRUl3TqgVCDsJibbIKBKovJESaoLvZkQHL3KZqRMTmtGKMMaXG2QXCKRTFHkE0FlC/4UWLUYSuvmQTjzsrQwqRrE+o0iLchrrKpUog1W3LPJWQKHTJya5UY6KO2ORBiG4WTPSI5LoMOr3OskU0yxDwwezoCCFYYb1mi4W42b4qb/jHCPODOaqjmp/jc20qer98qSTZd2637XPD2me5rjDvuHgrr/r4HYDA+ICCzM9LmdR0Or2MjeVU9rWL1n/VvPqPFUqsQ6ZLEsBR1R2eh42cvpuBgeRBYep7+hfgMudqpM74FSew3+qrcZZHuoAlZrIXmKBXI/A1O0LwFKbzmwG/3TBApxzXa7x04TPXmkVCvyggBNrsI07SfRaZV6AmL+FGnVysYKXsSkGDAHRNBZlmfooOPgljF/YgsoZrpWME9Rnr4kgfcAjwMhJPXzJmXmddaoWD/nA9YiEqCyJeHBSgw2Ykxzfqs2E8aBrF1PH40c0OWHoOFBoTI2lt0TFDh2jTW40VuhXVApmiGL+4fSykcHzOoNo4oMjmTCopga15RIPWm1JUZR2hVERbY7edubUyrB+2WydJM+yGwRDjQPwJp+8t1HuZxoXaKoDqlocZoAMVjKHGFmDstn9S6eTEIbc1qzbUlwZbk/rBr5U0bZJ4e7h06j/9e7hz/5uWAI4CSTr+VDNASqP50RivZHDvKA8oobIG/78vbA1hATrsnStvwa2Ig/ti1nbOsXhQcs9DGKlx8fES69FqVFw1bJvMmc1LvLglzrsK51cPa4ZsFs3vAjmw/xIr6Az3CWCmTEbi1TXSgJSUESg6vttBarMWOf3mhJ92mJhgiaQWBtXrH2SdQ0EchGWSWijNYhASVJXZWHWdSHh/evBOrtMGSEip/gV06a0Uf1N3XyoZfYS1n+kV/jO41Fw5XZMA3g5ZgHN49HVZQ3IrjLdJiy9/HaXfbC3OpcSTxgpUiTcCceKRmkjJ9xaXZXQr9n8KPwAew9O2Vc3g/vLGvy8lJY6vs33QFqqqC4LByxwAHB4g8Dew2A8RoPevlI1/ddB7wCiRw+fPnb7r5AdHPhO4bUgNvBTBStOmR0tMrtMvyDCYO8s3hMzS64B7VBIANDibddItd1dFzApHMoCRA70kquY1HUMWr+PWbuTQZsvZbSX0vNBQJy032Rd/3/aWVKXBlHLTZ2Np7E1rN9AFK+w6XcZ177fyQNOxwHaPKn+0LvTz83px9uc/uG9aXORZRjlEjNzA2UySN2s3KDOq8Vlnp+/N5zOX3R97g+HD38danXLQ/MPt7VtQO21RFgfz3MUcSTiF9vAOn/6f43U//TCeLB1cc2Pb9oRt4SlqLbfuEzuXAcLoWcDkBRiRrUgCytvnxkyU+prwW23Ni9vXGL3QMPUtf/P/fXn/vpzf10TPuTOjErfIvsKZ9GBQwiH7fRVskP6A4gOhu99Bdua+gBioz+9Cmf/cp8x6gpOrcq+qoQcbr9bo4NcYKhZ8ah6dKnXkauAw7/oXF1YqD8UKhtGTZI5bEySiNrEB6ukYQqhzl7WokMa2qgVw0n8p3CPRzHQTH3GRvQ/JMa49LEQ/8LtQZHYjasQOA3DuKzB1/VTknM2wV6K438B)

Probably related to the fact that post processing only uses depth from one of the frustums. Log depth typically only uses one frustum.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in the linked Sandcastle example with log depth disabled, then trace how silhouette post-processing obtains depth from the frustums. Confirm whether it only reads one frustum and determine the relevant rendering entry points. Done means the silhouette highlight works correctly when log depth is disabled, including the reported Sandcastle case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.