CesiumGS / CesiumGS/cesium

Sharp lighting transition in 2D

Open
#7,277 1 comment 0 reactions 0 assignees View on GitHub
category - 2d / columbus view type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

Git bisect points to https://github.com/AnalyticalGraphicsInc/cesium/commit/85b08e56fde4991ab0524d9b4f85c6418d55915f when lighting fade changes were made. @bagnell do you know what might be causing this?

[localhost Sandcastle](http://localhost:8080/Apps/Sandcastle/index.html#c=ZVDLbsIwEPwVKxdSCTlqjyQgpJQb0Eqp4OKLk2yDxcamayeUVv33OqQIQn3beezMupXEjoawfAMiqTSbshSsampeEEgH2xsu/Baa+Ufw0YB1W0/TStr9hDlqYDwgN0AOPteGaom2Fwj98xALLXTrM1sFRyCfpuF4SdycsXBUnMfUaOdDgUZj9hfs+h6vZFpVAk0Gza/rz2u4LUADr9DkwEHLHGGpqp1TuvKpXZ/4TlqbEq7nZx228hDP0sV68fQcB+Mgse6EMOvbzFV9MORYQxhyHjmoD+i/xEZ5U+zB8cLarlASXUxJqVqmyqkI7i4UAStQWuuZ9wYxU18gglkSef3AhkaWvv9LC4Ty1El2j7NlD3LOk8iP/13OGMwl3Wz8BQ)

![lighting](https://user-images.githubusercontent.com/915398/48814416-a0e9d380-ed08-11e8-9a71-f9e16aa732a8.gif)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the sharp 2D lighting transition in the linked localhost Sandcastle example, then inspect commit 85b08e56fde4991ab0524d9b4f85c6418d55915f and the lighting fade changes it introduced. Compare the behavior before and after that commit; done means identifying and correcting the regression so the lighting transition is no longer visibly sharp.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.