Why does BaseLayerPickerViewModel set depthTestAgainstTerrain ?
- Dominant language
- JavaScript
- Stars
- 15.7k
- Forks
- 3.9k
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 34
Description
https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Widgets/BaseLayerPicker/BaseLayerPickerViewModel.js#L247
This recently led to some confusion in behavior in https://github.com/AnalyticalGraphicsInc/cesium/issues/6990
I don't think BaseLayerPicker should be setting this option. This seems like a decision the developer should make, not the widget.
We also set `depthTestAgainstTerrain` in `CesiumInpector`. I think I did this initially because one of the features needed it, but we should see if we can remove it from there now too.
Thoughts? @mramato @emackey
Contributor guide
Research direction
Start with Source/Widgets/BaseLayerPicker/BaseLayerPickerViewModel.js around line 247 and inspect the CesiumInpector location where depthTestAgainstTerrain is also set. Review issue #6990 and the referenced feature's needs; done means determining whether both widget-level assignments can be removed without changing intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100