CesiumGS / CesiumGS/cesium

Better hook into geocoder search command

Open
#6,988 1 comment 0 reactions 0 assignees View on GitHub
category - widgets
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

Currently there isn't a great way to execute code after `search` is executed on `GeocoderViewModel`.

- `GeocodeViewModel.search` is a command so we can listen to the `afterExecute` event, but this doesn't wait for the geocode promise to complete
- The `GeocodeViewModel.complete` is raised only after the geocode is successful and the camera flight finishes

What do I do when `search` is executed and either the geocode is not executed or the geocode promise fails?

Contributor guide

Open the contributing guide

Research direction

Start by reading the GeocoderViewModel.search command and its complete event, as named in the issue. Trace how unsuccessful searches and rejected geocode promises are handled. Done would mean the issue specifies and implements a reliable hook covering those outcomes, with tests for each case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.