non halting loop on equal or very close start, stop times
Open
Nobody has claimed this yet.
type - bug
- Dominant language
- JavaScript
- Stars
- 15.8k
- Forks
- 3.9k
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 34
Description
https://github.com/AnalyticalGraphicsInc/cesium/blob/c292a33a27954004eaba0f08b75a667b4fbcbc4e/Source/Core/Clock.js#L300
suggest replace with
Math.min(
JulianDate.secondsDifference(currentTime, stopTime),
JulianDate.secondsDifference(stopTime, startTime)
)
in the increment.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Source/Core/Clock.js around line 300 and inspect the increment logic for equal or very close start and stop times. Reproduce the non-halting loop, then verify that the increment no longer hangs in those cases and that normal clock behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100