Event listeners are not being removed when an entity is destroyed
- Dominant language
- JavaScript
- Stars
- 15.7k
- Forks
- 3.9k
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 34
Description
Adding entities (or any kind of Cesium object with a definitionChanged object) to an Entity as a non-standard key causes a listener to be added to it, and not removed.
Here's a Sandcastle example showing the issue: https://cesiumjs.org/Cesium/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=f0bbec7cd261365aaadd3bb991c4261c
Reported on the forum here: https://groups.google.com/forum/#!topic/cesium-dev/bRk7kmcApeo
Contributor guide
Research direction
Start by reproducing the issue in the linked Sandcastle example, then trace how non-standard Entity properties with a definitionChanged object register listeners. Done means the listener is removed when the Entity or contained object is destroyed; the linked forum report provides additional context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100