CesiumGS / CesiumGS/cesium

Implicit WebGL extension requirements

Open
#4,988 0 comments 0 reactions 0 assignees View on GitHub
category - graphics onramping type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

The following tests check for implicit WebGL extension requirements:
* `Scene/Primitive renders with distance display condition per instance attribute` (floatingPointTextures)
* `Scene/GroundPrimitive renders with distance display condition per instance attribute` (floatingPointTextures)
* `Scene/BillboardCollection renders more than 16k billboards` (instancedArray)

The first two should be have a fallback in the display condition implementation (would have expected this to be in #4700) and the last one should also have a fallback in the implementation that does not require instancing and uses multiple draw calls instead of uint32 indices.

Workarounds were added to the tests in #4986.

Contributor guide

Open the contributing guide

Research direction

Inspect the three named Scene tests and the workarounds added in #4986, then review the display-condition and billboard rendering implementations involved in those tests. Done means the tests no longer require floatingPointTextures or instancedArray extensions, while preserving the requested fallback behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.