CesiumGS / CesiumGS/cesium

The lighting/shadows situation is a little weird

Open
#4,030 1 comment 0 reactions 0 assignees View on GitHub
category - graphics category - lighting theme - visual quality type - enhancement
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

I don't have a great solution, but I wanted to write an issue to start a discussion regarding our current lighting/shadow situation.
1. If you have lighting on and zoom in to the dark side of the earth, the lighting fades out when you get close to the ground. (I like this behavior).
2. If you have lighting on and terrain with normal lighting on, the lighting stays dark when you zoom in. (otherwise I guess the terrain would end up not lit at all)
3. If I have shadows on, but lighting off it still acts as if lighting is on except that the atmosphere is still drawn on the dark side of the world.

Perhaps having shadows on should force lighting on, that would get rid of 3? The current mix of behavior is kind of confusing from an end-user point of view. Perhaps an enum would help here, I'm not sure.

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Begin by reproducing the three lighting and shadow combinations described in the issue; this needs an agreed expected behavior before implementation can be considered done.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.