PolylineGeometry removing duplicates will impact other per-vertex data
Open
category - polygons/geometry
type - bug
- Dominant language
- JavaScript
- Stars
- 15.7k
- Forks
- 3.9k
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 34
Description
Compacting the positions array using PolylinePipeline.removeDuplicates() here...
https://github.com/AnalyticalGraphicsInc/cesium/blob/1.11/Source/Core/PolylineGeometry.js#L306
Will have an offsetting effect on other per-vertex data (such as color) since those arrays aren't being compacted in the same way.
Contributor guide
Research direction
Start at Source/Core/PolylineGeometry.js around line 306 and inspect how PolylinePipeline.removeDuplicates() changes the positions array. Trace the other per-vertex arrays, such as color, and verify that duplicate removal preserves their alignment; done means the affected geometry data remains correctly associated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100