CesiumGS / CesiumGS/cesium

computeTemeToPseudoFixedMatrix may have problems near leap seconds.

Open
#2,846 0 comments 0 reactions 0 assignees View on GitHub
category - math type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

The three tests below all fail if you change date from `June 29, 2015 12:00:00 UTC` to `June 30, 2015 12:00:00 UTC` (which is near a leap second). The problem is that either these tests simply don't work if crossing a leap second (and hardcoding the dates as done in #2845 is the actual solution), or there is a bug somewhere that needs to be fixed. We should determine the exact cause of the failure and close this if the tests were bad, or fix the bug if it's our computation.

```
computeTemeToPseudoFixedMatrix works before noon
computeTemeToPseudoFixedMatrix works after noon
computeTemeToPseudoFixedMatrix works with a result parameter
```

Contributor guide

Open the contributing guide

Research direction

Start with the three tests named in the issue: “computeTemeToPseudoFixedMatrix works before noon,” “works after noon,” and “works with a result parameter.” Compare their behavior on June 29 and June 30, 2015, then determine whether the failure is caused by invalid test dates near the leap second or by the computation; done means either correcting the tests or fixing the computation and restoring passing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.