CesiumGS / CesiumGS/cesium

numberOfVerticalLines does not always work for CylinderOutlineGeometry

Open
#2,337 2 comments 0 reactions 0 assignees View on GitHub
category - graphics type - bug
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

[Local link](http://localhost:8080/Apps/Sandcastle/index.html?src=Cylinder%20Outline.html)

![image](https://cloud.githubusercontent.com/assets/1495196/5510893/65232400-8795-11e4-98a0-d52b97312326.png)

As you increase `numberOfVerticalLines`, it gets lopsided to one side. True 24 and you'll see it, 90 makes it obvious.

Contributor guide

Open the contributing guide

Research direction

Start with the Cylinder Outline Sandcastle example linked in the issue and reproduce the lopsided output with numberOfVerticalLines set to 24 and 90. Then trace the CylinderOutlineGeometry implementation to find how vertical lines are positioned; done means increasing the value produces a symmetric outline rather than shifting it to one side.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.