CesiumGS / CesiumGS/cesium

Refactor model pipeline factoring in OIT pass

Open
#12,914 4 comments 0 reactions 1 assignee Claimed by @danielzhong View on GitHub
Dominant language
JavaScript
Stars
15.7k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

In the glTF edge visibility PR, there are cases where shader output declarations conflict with OIT’s output layout, even if the code paths are not executed in the OIT pass.

I introduced a temporary solution:
A new flag CESIUM_REDIRECTED_COLOR_OUTPUT was introduced to indicate that a shader has been derived/modified by Cesium’s rendering pipeline. This allows MRT features and other passes to conditionally declare output variables only when not conflicting with the redirected shader outputs.

However, we should consider a broader refactor of the model pipeline to handle this issue in a more systematic way.

https://github.com/CesiumGS/cesium/pull/12859

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.