CesiumGS / CesiumGS/cesium

PolygonGeometry with holes have broken surfaces

Open
#12,294 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type - bug type - regression
Dominant language
JavaScript
Stars
15.8k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

What happened?

Now I have encountered a problem when changing from version 1.119 to versions after 1.120.
I created a PolygonGeometry that provides polygon boundary coordinate data and polygon hole coordinate data to create a polygon with holes. Generally, there is no problem with the coordinate data of holes, but many boundary coordinates in urban areas may have holes and broken surfaces.
The city boundary coordinate data is arranged in order and is valid latitude and longitude data in terms of format. It can be successfully rendered as PolylineGeometry or PolygonGeometry, but using the city coordinate data as polygon hole coordinate data may result in broken surfaces.

PolygonGeometry with holes created in version 1.119:
1 119

PolygonGeometry with holes created in version 1.120 has a broken surface in the lower left corner, and most of the city boundary coordinates have a broken surface in the lower left corner:
1 120

Reproduction steps

No response

Sandcastle example

No response

Environment

Browser:
CesiumJS Version:
Operating System:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing PolygonGeometry behavior between versions 1.119 and 1.120 using polygon boundary and hole coordinate data from the report, then inspect the geometry and surface-generation path involved. There is no Sandcastle example, reproduction test, browser, or operating-system information; done means reproducing the lower-left broken surfaces and restoring correct rendering for polygons with holes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.