Terrain skirts are causing artifacts in terrain shadows
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 15.8k
- Forks
- 3.9k
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 34
Description
When terrain shadows are enabled, the skirts contribute in casting shadows causing shadows artifacts.
This is better visible when the light source is tangent to surface (e.g. it is near the horizon).
I'm attaching a simple sandcastle example for demonstrating the current behavior: advance the time through the timeline for seeing the shadows artifacts caused by the skirts. Disabling the terrain skirts gets rid of some of those artifacts, but that of course has some other bad side effects, e.g. worse tiles edges connection
Sandcastle example:
Sandcastle
Ideally, I solid shadow should be casted when the light is low and the light source is occluded by a skirt "wall". Something like in the following animation
Browser:
any
Operating System:
any
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the linked Sandcastle example and reproducing the artifacts with terrain shadows enabled, especially when the light is near the horizon. Investigate terrain skirts' shadow behavior; done means low-angle lighting produces solid skirt-wall occlusion without the reported shadow artifacts or disabling skirts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100