CesiumGS / CesiumGS/cesium

Use `Model` for `.vctr` and `.geom` contents

Open
#10,706 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

category - model/gltf
Dominant language
JavaScript
Stars
15.8k
Forks
3.9k
Avg merge
4d 6h
Merged PRs (30d)
34

Description

Right now, vctr and geom contents still use custom classes (Vector3DTileContent and Geometry3DTileContent).

This would involve:

  1. Making VctrLoader to parse .vctr files and transcode to a ModelComponents instance, much like B3dmLoader does for .b3dm file
  2. Similarly, make a GeomLoader for .geom files.
  3. Add pipeline stages to Model as needed to implement any unique functionality
  4. Check that picking/styling works with ModelFeatureTable instead of the old Cesium3DTileBatchTable

Ideally, at the end of this, nothing will use Cesium3DTileBatchTable (vctr and geom were the main stragglers), and we can consolidate that class with ModelFeatureTable to make things simpler.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the planned VctrLoader and GeomLoader with B3dmLoader, then trace how ModelComponents and Model pipeline stages handle the existing vctr and geom paths. Inspect picking and styling through ModelFeatureTable versus Cesium3DTileBatchTable. Done means both formats use Model, their unique behavior works, and the old batch table is no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.