CesiumGS / CesiumGS/cesium-unity
Enable warnings-as-errors in our C++ code
Open
quality
- Dominant language
- C#
- Stars
- 535
- Forks
- 132
- Avg merge
- 6h 45m
- Merged PRs (30d)
- 1
Description
Our cesium-unity C++ code has quite a few warnings, as I discovered when CesiumGS/cesium-native#1289 inadvertently turned them into errors. This has now been fixed (CesiumGS/cesium-native#1295). We should purposely enable warnings-as-errors in cesium-unity and fix them all.
I fixed some but not all of the warnings in #644.
Contributor guide
Research direction
Review issue #644 and the warning fixes already made there, then inspect the cesium-unity C++ build configuration and warning output to locate the remaining warnings. Done means warnings-as-errors is enabled and the full warning set is clean.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100