CesiumGS / CesiumGS/cesium-native
nonstd::expected includes windows.h when exceptions are disabled
- Dominant language
- C++
- Stars
- 623
- Forks
- 277
- PR merge metrics
- No merged PRs in 30d
Description
Including windows.h is a fairly disastrous thing to do in many project. We can probably avoid it by setting [-Dnsel_CONFIG_NO_EXCEPTIONS_SEH=0](https://github.com/martinmoene/expected-lite#enable-seh-exceptions).
See https://community.cesium.com/t/unable-to-package-ue5-0-3-project-with-cesium-v1-19-0/21162/19
Contributor guide
Research direction
Start by locating where expected-lite is configured or included in the C++ build, then reproduce a build with exceptions disabled and inspect whether windows.h is pulled in. The issue's suggested NO_EXCEPTIONS_SEH setting is the starting point; done means the affected configuration no longer includes windows.h and still builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100