CesiumGS / CesiumGS/cesium-native

`GltfUtilities::computeBoundingRegion` set PoleTolerance by Tile

Open
#1,217 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
623
Forks
277
PR merge metrics
No merged PRs in 30d

Description

`GltfUtilities::computeBoundingRegion` need to add an input field for tile height to set pole tolerance as stated in the comments, i.e. `computedBounds.setPoleTolerance(0.001 * tileHeight);` for

https://github.com/CesiumGS/cesium-native/blob/70bd62a9f4883d26def3d1dddd08c6a67217ec86/CesiumGltfContent/src/GltfUtilities.cpp#L222

as in

https://github.com/CesiumGS/cesium-native/blob/main/CesiumRasterOverlays/src/RasterOverlayUtilities.cpp#L110

Contributor guide

Open the contributing guide

Research direction

Start with CesiumGltfContent/src/GltfUtilities.cpp at computeBoundingRegion and compare the related logic in CesiumRasterOverlays/src/RasterOverlayUtilities.cpp. Add the tile-height input and verify that the resulting pole tolerance is set to 0.001 times the tile height, as described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.