CentreForDigitalHumanities / CentreForDigitalHumanities/tscan
Typing of sentStats::sv should ideally be a wordStats instead of a basicStats
- Dominant language
- C++
- Stars
- 19
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
See:
https://github.com/UUDigitalHumanitieslab/tscan/pull/61#discussion_r990038148
The problem is that `struct basicStats` (which is the base for `wordStats`) contains the definition:
https://github.com/UUDigitalHumanitieslab/tscan/blob/bec422ccb74a3c88ef329dfbc0b925021d0bf8fa/include/tscan/stats.h#L107
This makes it harder to introduce generic type because this would introduce a circular type dependency e.g.:
```cxx
typename T
struct basicStats {
...
std::vector sv;
}
struct wordStats: public basicStats> {
...
}
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the `struct basicStats` definition in `include/tscan/stats.h` and read the linked discussion in pull request #61. Trace how `sentStats::sv` and `wordStats` are related, then define what type relationship would avoid the proposed circular dependency; done means the typing design is agreed and implemented without that dependency.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100