CentreForDigitalHumanities / CentreForDigitalHumanities/microcontact
Spurious assertion failure in client/script/view/contributionPie.coffee
Open
bug
least concern
- Dominant language
- Python
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The following assertion fails on some larger pies because of rounding differences. The tested value is not exactly 1, but (for example) 0.99896 or 1.004721. Which is definitely close enough, but the assertion doesn't reflect this yet.
https://github.com/UUDigitalHumanitieslab/microcontact/blob/0745026e36090568c5b33b165525bcc2acb34366/client/script/view/contributionPie.coffee#L42
Change to an assertion that the value is *close to* 1.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.