CentreForDigitalHumanities / CentreForDigitalHumanities/luupzig

Support editing

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I definitely see a possibility of integrating this with Excalibur in a shared library.
Some of my initial thoughts:

- All the editing functionality in Excalibur's component should be turned off in some views. When `edit=False` it can behave exactly as what you've created here.
- When editing glosses, I think it's more convenient to handle all layers simultaneously in one model (see `Gloss` in Excalibur). Maybe `luupzig` could support two modes: supply a single gloss model, or define multiple lines explicitly as done here.
- Because Excalibur is still in early development, I wouldn't want to immediately spend time working on a nice and well designed library. I'd prefer to return to this at a later time, when the application is a bit more fleshed out.

_Originally posted by @bbonf in https://github.com/UUDigitalHumanitieslab/mima/issues/41#issuecomment-1514680102_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the existing component and compare its editing behavior with Excalibur's component, especially the `edit=False` case and the `Gloss` model mentioned in the issue. Confirm the intended integration scope and whether support should cover a single gloss model, multiple explicit lines, or both; the issue does not yet define a concrete done state.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.