CentreForDigitalHumanities / CentreForDigitalHumanities/langpro-annotator

Outfactor component logic in ManageLabelsModal

Open
#68 1 comment 0 reactions 0 assignees View on GitHub
bonus enhancement
Dominant language
TypeScript
Stars
0
Forks
0
Avg merge
5d 11h
Merged PRs (30d)
2

Description

~Not all tests that are currently written as component tests (e.g. those for `getAttachedByText` in the `ManageLabelsModalComponent`) should be component tests.~

Parts of the logic that are now in the ManageLabelsModal are not strictly tied to that component. They should be outfactored.

> These are tests for a component, which is a view and a controller in the MVC triangle, but I think the tested behavior belongs in the model layer. Indeed, it looks like something that could fairly easily exist indepently of the component.

_Originally posted by @jgonggrijp in https://github.com/CentreForDigitalHumanities/langpro-annotator/pull/64#discussion_r2683922944_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.