CentreForDigitalHumanities / CentreForDigitalHumanities/langpro-annotator

Fix 'equal_to' knowledge base relationship

Open
#132 0 comments 1 reaction 1 assignee Claimed by @XanderVertegaal View on GitHub
bug
Dominant language
TypeScript
Stars
0
Forks
0
Avg merge
5d 11h
Merged PRs (30d)
2

Description

The mapping between knowledge base relationships and LangPro prover input is not correct in `backend/problem/utils.py`. Currently, `equal` and `subset` are both converted into single `isa_wn(...)` items and for `subset`, this is correct. For `equal`, however, there should be two.

```
Input:
{
"id": "1",
"entity1": "Hesperus",
"entity2": "Phosphorus",
"relationship": "equal"
}

Current output: "isa_wn(Hesperus, Phosphorus)"
Expected output: ["isa_wn(Hesperus, Phosporus)", "isa_wn(Phosphorus, Hesperus)"]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.