CentreForDigitalHumanities / CentreForDigitalHumanities/Textcavator

Shared `onWindowScroll` function for search bar

Open
#829 0 comments 0 reactions 0 assignees View on GitHub
code quality frontend
Dominant language
Python
Stars
12
Forks
3
Avg merge
3d 3m
Merged PRs (30d)
9

Description

https://github.com/UUDigitalHumanitieslab/I-analyzer/blob/c40fc59a5d44626070e575e742b6c1e5d896e0f4/frontend/src/app/search/search.component.ts#L104-L108

https://github.com/UUDigitalHumanitieslab/I-analyzer/blob/22d31deef041a8f8a8bf16c6bb3579a2d6ce0f1e/frontend/src/app/word-models/word-models.component.ts#L103-L107

In the interest of DRY: perhaps we can make `onWindowScroll` part of a mixin to be used by Search / WordModel components.

_Originally posted by @BeritJanssen in https://github.com/UUDigitalHumanitieslab/I-analyzer/pull/820#discussion_r959474747_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.