CentreForDigitalHumanities / CentreForDigitalHumanities/Textcavator

consolidate_start_end_years does nothing

Open
#1,812 0 comments 0 reactions 0 assignees View on GitHub
backend bug
Dominant language
Python
Stars
12
Forks
3
Avg merge
3d 3m
Merged PRs (30d)
9

Description

This concerns this function the backend:

https://github.com/CentreForDigitalHumanities/I-analyzer/blob/83e49633c507ff7772786247f6182b2ccd6975fc/backend/addcorpus/python_corpora/corpus.py#L519-L547

This function is used in the dutchnewspapers and times corpus definitions. The docstring is clear, but does not seem to match the body of the function, which appears to have no effect. (No assertions, no return value, no side effects.)

Implicitly, the function performs type-checks on the provided variables. We recently made some changes in the types for the time range of a corpus, e.g. https://github.com/CentreForDigitalHumanities/I-analyzer/pull/1742, which required some changes to this function. Perhaps something got lost here?

**To do:**
- Add a unit test for this function based on the docstring
- Correct the function if the test fails

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.