CentreForDigitalHumanities / CentreForDigitalHumanities/Textcavator

Visualization footer still visible when request to backend has failed

Open
#1,426 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
12
Forks
3
Avg merge
3d 3m
Merged PRs (30d)
9

Description

### What went wrong?

This is really not a big issue, but after a failed request for a visualization, the visualization footer with "download" buttons etc. is still visible.

### What did you expect to happen?

It would be better if we only saw the error message here.

### Screenshot

Screenshot 2024-02-08 at 14 09 24

### Where did you find the bug?

- [ ] https://ianalyzer.hum.uu.nl
- [ ] https://peopleandparliament.hum.uu.nl
- [ ] https://peace.sites.uu.nl
- [ ] a server hosted elsewhere (i.e. not by the research software lab)
- [X] a local server

### Version

5.4.0

### Steps to reproduce

Cause a request vor a visualization to fail (e.g., by throwing an error from the backend temporarily), request a visualization and observe.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the failed visualization request on a local server, then trace the error handling and visualization footer rendering. Done means the error message remains visible while the footer and its download buttons are hidden after the backend request fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.