CentreForDigitalHumanities / CentreForDigitalHumanities/Textcavator

Construct ES queries in backend

Open
#1,349 1 comment 1 reaction 0 assignees View on GitHub
backend code quality frontend
Dominant language
Python
Stars
12
Forks
3
Avg merge
3d 3m
Merged PRs (30d)
9

Description

I'm making this issue mostly as reference point, as the idea has come up a few times (e.g. #1292 , #1099 )

For the most part, elasticsearch queries are constructed entirely by the frontend and forwarded to elasticsearch by the backend. There are some exceptions to this:

- The backend analysis for visualisation often includes adjustments to the search query, such as adding extra filters.
- Since 5.3.0, a query to the backend includes an `es_query` and an optional key `tags` that specifies user tags to filter on.

It would be more consistent if we moved the conversion to and from an elasticsearch query _entirely_ to the backend and used an I-analyzer-specific "intermediary representation" in the API.

This makes it easier to implement certain features (such as tagging).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.