CenterForDigitalHumanities / CenterForDigitalHumanities/TPEN28

AnnotationLists not formatted correctly

Open
#78 1 comment 0 reactions 1 assignee Claimed by @markskroba View on GitHub
capstone enhancement
Dominant language
Java
Stars
4
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When a user resolves an annotation lists they do not come out very pretty. See:

http://165.134.241.141/annotationstore/annotation/58077147e4b0ebd2e475cb5e

This is in contrast to the pretty manifests and canvases we return. See

http://165.134.241.141/TPEN28/canvas/105421

and

http://165.134.241.141/TPEN28/manifest/5330/manifest.json

I know there is a java package used in the canvas and manifest servlets that formats the output into pretty JSON (JsonLDExporter) that has been used there since I started using the code. The problem here is that AnnotationsLists come out of the annotation store, as will manifests and canvases once we have that working properly.

That means the output from the annotation store is not formatted, so I may need to try to implement something like the JSONLDExporter class in the annotation store.

I also notice that the data itself is not very clean, mainly because it still returns the object field _id which is full of junk. We should make the annotation store strip that field before returning.

Probably just an hour or two worth of work. Not a big problem, just its very noticeable when you get a canvas or a manifest via a browser then get the annotation list then resolve that URL. It look sloppy.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.