CenterForDigitalHumanities / CenterForDigitalHumanities/TPEN28

Image Streams Don't Resolve To Be Cached

Open
#704 0 comments 0 reactions 0 assignees View on GitHub
interoperability
Dominant language
Java
Stars
4
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When `getUncachedImageStream` cannot resolve the URL, it will use Image dimensions `1, 1` instead of being omitted or using/returning `0, 0`. This means the Canvases with these images are all `1000, 1000` and the images themselves are all `1, 1` in the Manifests, which will absolutely wreck all attempts at interoperability. However, somehow the TPEN interface manages because after some time it does resolve the image.

Our best idea, already referenced in #703, is to let the interface detect this scenario and after it loads the images and has dimensions to update the cached dimensions for the folio (per folio, one at a time, as the interface resolves the image so the user will not experience any extra delay).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the getUncachedImageStream entry point and read the discussion in #703 to understand how unresolved image URLs currently produce dimensions. Trace how those dimensions reach canvases and manifests, then verify that unresolved images are not recorded as 1,1 and that resolved dimensions can update the cached folio values one folio at a time.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.