CenterForDigitalHumanities / CenterForDigitalHumanities/TPEN-services

code change may cause early exit on error

Open
#487 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

> The function changes from `forEach` to `for...of`, but then returns early from within the loop body. The early return will exit the entire function, not just the loop iteration. This is likely a bug - the original `forEach` would have continued to check other environment variables. If an early exit is intended for the first missing variable, this works correctly, but verify this is the desired behavior.

_Originally posted by @Copilot in [#431](https://github.com/CenterForDigitalHumanities/TPEN-services/pull/431/changes#r2608032650)_

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.