CenterForDigitalHumanities / CenterForDigitalHumanities/TPEN-services

driver and controller find(query, collection)

Open
#149 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Remove the `collection` dependency. See #139

```
You could { query, collection } if you wanted, but they are not the same, which is why its separate. collection is the db channel and the query is the payload. There are ways in Mongo to combine it, but not with our RERUM API

I know, it's tricky. @type seemed like a way to connect the wires so we didn't always have to do payload AND collection. However, that meant @type and now we don't think @type is a good idea for our objects.

We need another way to determine collection off the payload, or we can explicitly pass it as a second parameter outside the payload parameter

"users" is the only valid thing with 'profile'
"groups" is the only valid thing with 'members'
"projects" is the only valid thing with 'group'
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.