CenterForDigitalHumanities / CenterForDigitalHumanities/DLA
Firefox Login
- Dominant language
- HTML
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
When using the Firefox Browser https://dunbar-poems.rerum.io/ (and others) actually trigger the login even when the button is disabled.
The Login process is a loop that does not result in a logged in user.
Notes from detecting the issue
> I wanted to be a Contributor in Firefox and a Reviewer in Chrome, that's why I found this corner
> Mircrosoft Edge works fine
> weird. Firefox is using the as this so it does not have disabled on it
> I think the best solution is a helper isDisabled() that just tries `this.getattribute('disabled') and this.querySelector('[is="auth-button"])...`
A continuance of this is to be sure this isn't breaking other parts of other apps that rely heavily on the DOM, such as DEER.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.