CarperAI / CarperAI/trlx

ModelConfig.tokenizer_path and TrainConfig.save_best

Open
#232 0 comments 0 reactions 0 assignees View on GitHub
documentation
Dominant language
Python
Stars
4.8k
Forks
487
PR merge metrics
No merged PRs in 30d

Description

### 📚 The doc issue

ModelConfig.tokenizer_path has perhaps moved to something like TokenizerConfig? It is under `tokenizer:` block in the yml config files. Also, `save_best` under TrainConfig is not documented in the readthedocs.

### Suggest a potential alternative/fix

_No response_

Contributor guide

Open the contributing guide

Research direction

Locate the definitions or documentation for ModelConfig.tokenizer_path, TokenizerConfig, and TrainConfig.save_best, then compare them with the `tokenizer:` YAML configuration block. Update the relevant ReadTheDocs pages so both settings are accurately described, and verify the rendered documentation matches the current configuration names.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.