Card-Forge / Card-Forge/forge

Player::descent via getCardsAddedThisTurn

Open
#9,730 1 comment 0 reactions 2 assignees Claimed by @tool4ever View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

replace Zone manual counting:
https://github.com/Card-Forge/forge/blob/6d697fbff8981825a99d6018bc5cd09f77b3a5fa/forge-game/src/main/java/forge/game/zone/Zone.java#L128-L130

with this Player function:
```java
public final int getDescended() {
return getZone(ZoneType.Graveyard).getCardsAddedThisTurn(null).stream()
.filter(c -> c.isPermanent() && !c.isToken()).count();
}
```
Or is the problem the LKI?

how are Descend rules for DFC that may or may not be Permanent?
Like `Extus, Oriq Overlord` is a creature on the front side, but Spell on the back
Like `Bloodsoaked Insight` is a Spell on the front side, but a Land on the back

Rules:
> 700.11. Some cards refer to whether a player has “descended this turn.” This means that a permanent card has been put into that player’s graveyard from anywhere this turn. “The number of times [a player] descended this turn” means “the number of permanent cards put into [that player’s] graveyard from anywhere this turn.” In both cases, no permanent cards put into the player’s graveyard that turn are required to still be in that graveyard.

`from anywhere this turn` does mean it doesn't look back. So it should count `Extus, Oriq Overlord`, but not `Bloodsoaked Insight`, right?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.