Dependency Layer 3
- Dominant language
- Java
- Stars
- 2.7k
- Forks
- 1.1k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 163
Description
Stuff that affects Text Change Layer:
* CardType
* TypeWordChange
* StaticLayer GainTextOf
* TextBox (CardTraits)
* TypeWordChange
* ColorWordChange
* StaticLayer GainTextOf
* TextBoxExchange
* Color
* StaticLayer GainTextOf
* Incorporate
* ManaCost
* TypeWordChange (over additional Cost, which should be traits)
* ColorWordChange (over additional Cost, which should be traits)
* StaticLayer GainTextOf
* Incorporate
* PT
* StaticLayer GainTextOf
First Section, CardType Changes:
For the small example of CardType Changes, i added #9375 to be to handle the TypeWordChange as Map.
But in reality, it should have handled them as Word per Word changes.
Right now, it `addChangedCardTypesByText` calls `addEmpty` on both TypeWordChange and ColorWordChange, even if the color words shouldn't be affected.
That is because it was made for `GainTextOf` before `TextBoxExchange` was introduced.
As a first attempt, I'm going to refactor the CardTypeChanges to not rely on the finished TypeWordChange Map, but single Word → Word changes instead. Then the `GainTextOf` Effect can better reset the entire CardType without the need for extra `addEmpty`, and it can be handled by `addChangedCardTraitsByText` for now.
Contributor guide
Assessment
This issue has not been assessed yet.