Card-Forge / Card-Forge/forge

Remove Static Commands from GameAction

Open
#9,359 3 comments 0 reactions 2 assignees Claimed by @tool4ever View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

some GainControl cards (2) use StaticCommandCheck, that causes it to be specially checked in GameAction

Old Man of the Sea
> for as long as Old Man of the Sea remains tapped and **that creature's power remains less than or equal to Old Man of the Sea's power.**

Rootwater Matriarch
> Gain control of target creature **for as long as that creature is enchanted.**

but it would be better if these two would be updated to use real Effect ones in the CommandZone,
then it would have Static Always Trigger to remove the Effect

and we could remove these extra code from GameAction

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.