Card-Forge / Card-Forge/forge

Perpetual Effect into Hidden Statics

Open
#9,241 2 comments 0 reactions 1 assignee Assigned to @Hanmac View on GitHub
Game Mechanics keep
Dominant language
Java
Stars
2.7k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
158

Description

Perpetual Effects should be changed into Hidden Statics, so while still applying, they use Layer System.

The outliner is ManaCost changes for `Thought Partition` and Incorporate.
It needs to apply before Layer 4 (Type-change)
someone might justify it as a text-change?
`Volrath’s Shapeshifter` already uses addChangedManaCost too

Also, their Timestamp might need a reset into negative or zero on zone change:

> (2) Once an object changes zones, the timestamp of the perpetual effect changes to, effectively, "negative infinity". That is, earlier than any other non-perpetual timestamp

https://www.reddit.com/r/MagicArena/comments/17pb9y9/comment/k8a98g3/

Some Perpetual Ability Effects, have LosePerpetual as its trigger.
So i need to get from the Trigger to the HiddenStatic to the Perpetual Effect

Also, Commander can clean up their Perpetual #4135
> you may choose to remove all perpetual effects on that Commander

Should probably be done via EmptySA?

Affected Layers:

* #9574: PerpetualManaCost and PerpetualIncorporate
* #7011: PerpetualTypes
* Layer 5: PerpetualColors and PerpetualIncorporate
* #7012: PerpetualAbilities and PerpetualKeywords
* Layer 7b: PerpetualNewPT
* Layer 7c: PerpetualPTBoost

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.